Skip to content
This repository has been archived by the owner on Jan 16, 2018. It is now read-only.

Improve prepay API to support all parameters. #214

Merged
merged 1 commit into from
Oct 14, 2015

Conversation

zxkane
Copy link
Contributor

@zxkane zxkane commented Oct 12, 2015

微信支付文档定义了更多可选参数,以及由某些参数值强制要求的其他参数。比如当trade_typeNATIVE时,必须指定参数product_id

目前的实现中没有很好的处理这部分,这个PR就是改进此问题。

@zxkane
Copy link
Contributor Author

zxkane commented Oct 13, 2015

@chanjarster 可否review一下这个改动,看看有没有什么问题?

@chanjarster
Copy link
Owner

感谢,我的源码的tab用的是两个空格,而不是一个tab字符,所以能否修改成这个风格,这样就能避免因为tab的原因看上去有大量修改,在此感谢。

@zxkane
Copy link
Contributor Author

zxkane commented Oct 13, 2015

如果你用的是Eclipse,可否把你的code formatter导出?之前没找到如何配置2个空格。

这个commit里面的改动涉及到的行(包括新增和修改的)确实都是4个空格开头,但没有改变源文件中未改动行的缩进。

@chanjarster
Copy link
Owner

你可能对代码做了格式化,一般这种问题的产生原因是无意之中ctrl shift f。

你可以看这个diff https://github.com/chanjarster/weixin-java-tools/pull/214/files

2015-10-14_08-51-43

2015-10-14_08-51-10

@zxkane
Copy link
Contributor Author

zxkane commented Oct 14, 2015

请review新的commit,修正了代码缩进。

chanjarster added a commit that referenced this pull request Oct 14, 2015
Improve prepay API to support all parameters.
@chanjarster chanjarster merged commit d87fe63 into chanjarster:develop Oct 14, 2015
@chanjarster
Copy link
Owner

感谢

@zxkane
Copy link
Contributor Author

zxkane commented Oct 14, 2015

可否release一个新的版本包含develop上最近的bugfix和这个改进?

谢谢!

Kane

On Wed, Oct 14, 2015 at 7:44 PM, Daniel Qian [email protected]
wrote:

感谢


Reply to this email directly or view it on GitHub
#214 (comment)
.

mgcnrx11 pushed a commit to mgcnrx11/weixin-java-tools that referenced this pull request Jul 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants